Skip to content

Update PartitionDay20.cpp #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update PartitionDay20.cpp #351

wants to merge 2 commits into from

Conversation

ARsh-ALgo
Copy link

Added few code lines for better readability for the user.

@ARsh-ALgo
Update PartitionDay20.cpp
d384a76 
Added few code lines for better readability for the user.
aaditkamat
aaditkamat suggested changes Oct 10, 2020
View reviewed changes
Copy link

@aaditkamat aaditkamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't comment on another set of changes that I thought I needed to be included, but you can add another print statement of line 22 to ask user to enter the partition size.

day20/C++/PartitionDay20.cpp
@@ -11,6 +11,7 @@ using namespace std;

int main(){
int n;
cout << "Enter the number of values you want to have."<<endl;
cin >> n;
int a[n];
for(int i = 0; i < n; i++){
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also add a print statement to inform user that he needs to enter a value (integer) each time.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey aadikamat,
Thanks for the suggestion. I have done the suggested changes.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a print statement before line 18 though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaditkamat aaditkamat aaditkamat requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ARsh-ALgo @aaditkamat